Repository navigation
v1.2.8: fix continuous scrolling + unified toolbar redesign - #106
Merged
Merged
Conversation
Fix the continuous view so it renders a full-document, virtualized layout instead of a sliding window around the current page: - one sized placeholder per page, so the scroll range spans the whole PDF - lazy pixmap rendering for the viewport plus overscan, with a bounded cache - scrolling updates the page indicator; navigation scrolls in place without rebuilding the layout or discarding pages; zoom preserves reading position - remove the undefined `_t` NameError in `_render_continuous` Replace the two stacked control rows with a single 44 px Fluent-style toolbar: consistent 18 px vector icons, 30 px targets, grouped file/page/zoom/annotation/search actions, live zoom percentage, a compact page counter, and a themed search field with a semantic toggle. Rewrite the light and dark stylesheets around a shared neutral palette with theme-aware scrollbars, menus, tabs, status bar, and empty state; regenerate icons and the empty-state glyph when the theme changes. Also refresh the page controls when switching tabs and hide the tab strip when no documents are open. Add regression suites for continuous scrolling and the toolbar/UI (22 new tests). Version bumped to 1.2.8 across main.py, the MSIX manifests, AppInstaller, and the MCP package. Co-Authored-By: Claude Code <noreply@anthropic.com>
Deploying reader with
|
| Latest commit: |
4a3d0c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d033bed.reader-bsl.pages.dev |
| Branch Preview URL: | https://feat-v1-2-8-toolbar-scroll.reader-bsl.pages.dev |
The new continuous-scrolling and toolbar tests need to protect the codebase, so run the full suite offscreen in the CI validate job. Co-Authored-By: Claude Code <noreply@anthropic.com>
A layout rebuild (zoom or tab switch) can leave the scrollbar range stale when the target page is applied, so the immediate render pass could paint the wrong pages and the settled target stayed blank until the next scroll. Schedule a render whenever the pending scroll is applied, and cover it with the zoom-retention test. Co-Authored-By: Claude Code <noreply@anthropic.com>
1100x820 gives the new toolbar breathing room on Windows font metrics; 720x480 keeps the empty state and overflow menu usable when resized down. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
The new pytest step exposed a missing optional dependency: the bundled MCP server builds its tool list at import time and needs `mcp.types.Tool`. Install requirements-mcp.txt in the validate job. Constrain the optional MCP dependency to 1.x. MCP 2.x moved the server API used by pdfreader_lib/mcp_server.py, so an unbounded requirement would install a version the v1.2.8 server cannot import. Verified on Python 3.11 with mcp 1.30.0: 160 passed, 18 skipped. Co-Authored-By: Claude Code <noreply@anthropic.com>
openreader-mcp imports mcp.types.Tool, which moved in MCP 2.x. Match the bundled server's requirements-mcp.txt constraint so `pip install openreader-mcp` does not resolve to an SDK the server cannot import. Co-Authored-By: Claude Code <noreply@anthropic.com>
- The release workflow now fails if MakeAppx is unavailable, and the publish job requires OpenReader.msix in the artifact set. - Tag pushes build and upload artifacts only. The GitHub Release is created only by a manual workflow_dispatch with publish=true, after the artifacts and version metadata have been verified. - Update the Store acceptance checklist to v1.2.8 (continuous scrolling, toolbar, themes, tab controls) and document the two-phase release. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the critical continuous-scrolling bug and replaces the outdated two-row toolbar with a single Fluent-style command bar.
Root cause — continuous scrolling
_render_continuous()did not build a document. It built a sliding window aroundcurrent_page(±5 pages):next_page()/jump_to_page()re-centred the window and deleted the previous widgets, so pages already read became unreachable;_perf_end(_t, …)referenced an undefined local, raisingNameErroron every continuous render.With a 76-page PDF the old code produced 6 widgets and a 3,101 px scroll range; it now produces 76 widgets and a 47,844 px range.
What changed
Continuous scrolling (virtualized)
Toolbar redesign
N / total), zoom (− 81% +and Fit), annotations, and search.Themes
Tabs
Verification
python -m py_compile main.py tools/create_icon.py scripts/inject_version.py— OKQT_QPA_PLATFORM=offscreen pytest tests/— 160 passed, 18 skipped (22 new tests: 9 continuous-scrolling regressions, 13 toolbar/UI regressions)Packaging
main.py,AppxManifest.xml(1.2.8.0),AppInstaller.xml, the MCP package, andPKG-INFOviascripts/inject_version.py.🤖 Generated with Claude Code